Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37560 )
Change subject: src: Conditionally include TEVT ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/chromeec/Kcon... File src/ec/google/chromeec/Kconfig:
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/chromeec/Kcon... PS3, Line 194: EC_SUPPORTS_DPTF_TEVT seems like this should be inserted at ln 3 'select EC_SUPPORTS_DPTF_TEVT' rather than be a separate, non-user selectable config item. Same for Wilco
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/wilco/acpi/dp... File src/ec/google/wilco/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/37560/3/src/ec/google/wilco/acpi/dp... PS3, Line 118: #ifdef HAVE_THERM_EVENT_HANDLER : /* DPTF will Notify sensor devices */ : _SB.DPTF.TEVT (Local2) : #endif seems unnecessary if all wilco EC boards/platforms have TEVT support, which appears to be the case