Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32845 )
Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................
mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT
Currently, GPP_H0 gpio input rout is set to GPI_INT. So, ACPI_GPIO_IRQ is required for GPP_H0 in devicetree This change also aligns hatch's setting.
BUG=b:131742713 TEST=headset is working
Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Signed-off-by: Kane Chen kane.chen@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32845 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Ben Kao ben.kao@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve Ben Kao: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 9546420..69875bd 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -90,7 +90,7 @@ chip drivers/i2c/da7219 # TODO: these settings were copied from another board # with the same chip. verify the settings - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_H0_IRQ)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_H0)" register "btn_cfg" = "50" register "mic_det_thr" = "500" register "jack_ins_deb" = "20"