Attention is currently required from: Nico Huber, Angel Pons.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73367 )
Change subject: memory_info: Switch to CONFIG_DIMM_MAX
......................................................................
Patch Set 6:
(1 comment)
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/73367/comment/f8dd495b_bff64524
PS1, Line 11: #define DIMM_INFO_TOTAL 64
Sorry for the slight on the other patch. This looks really like it should use […]
Currently DIMM_MAX is only about DIMMs, but not memory down. I believe DIMM_INFO_TOTAL currently also covers memory down.
Maybe a new Kconfig would be needed that calculates as "memory down devices + "DIMM slots"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52d77c4e9bff96adba6d265a272e0e425dbdb791
Gerrit-Change-Number: 73367
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Naresh
naresh.solanki.2011@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 22 Mar 2023 08:47:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment
