Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32519 )
Change subject: mb/google/sarien: Turn off camera power when s0ix
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/32519/8/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32519/8/src/mainboard/google/sarien/variants...
PS8, Line 15: #define CAM_EN GPP_B11 /* Active low */
add a newline
https://review.coreboot.org/#/c/32519/8/src/mainboard/google/sarien/variants...
PS8, Line 18:
Add a newline before the { for a method
https://review.coreboot.org/#/c/32519/8/src/mainboard/google/sarien/variants...
PS8, Line 20: Printf ("OS Enter S0ix")
There is already a debug output in the EC S0ix handler so we probably don't need a duplicate.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a9b7ec1e95cc9931d8d5f2dc1254805c9d0ffed
Gerrit-Change-Number: 32519
Gerrit-PatchSet: 8
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 May 2019 16:32:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment