Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45848 )
Change subject: soc/intel/xeon_sp/skx: Make devicetree config and ops generic
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45848/3/src/soc/intel/xeon_sp/skx/c...
File src/soc/intel/xeon_sp/skx/chip.h:
https://review.coreboot.org/c/coreboot/+/45848/3/src/soc/intel/xeon_sp/skx/c...
PS3, Line 10: struct soc_intel_xeon_sp_config {
This struct needs to be found inside `soc/intel/xeon_sp/chip.h`. #include directives would work.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4509d54371aca02cc96f7a18821fac8ce5404aa
Gerrit-Change-Number: 45848
Gerrit-PatchSet: 5
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 03 Oct 2020 03:51:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment