Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36547 )
Change subject: security/vboot: Add config option to always enable the display ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36547/1/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/36547/1/src/security/vboot/Kconfig@... PS1, Line 170: config VBOOT_ALWAYS_ENABLE_DISPLAY I think I'm following, but can you please explain why VBOOT_MUST_REQUEST_DISPLAY cannot be modified in how it's currently used. I understand all of our chipsets seem to be selecting VBOOT_MUST_REQUEST_DISPLAY which is preventing you from ensuring the display is requested to be initialized. But doesn't that just make the current setup incorrect for your purposes? And why is adding another Kconfig better? Did you try other approaches?