Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26346 )
Change subject: soc/intel/common/block/cpu: Use core apic id to get cpu_index() ......................................................................
Patch Set 10:
Patch Set 10:
(1 comment)
Why is it needed? As far as I understand FSP 2.1, that
introduced
MP_SERVICES_PPI, also introduced shared stack when selecting FSP_USES_CB_STACK. Simply select FSP_USES_CB_STACK when using MP_SERVICES_PPI
should
fix the issue.
The reason is that, on FSP2.0 platform also we might need to
enable MP PPI feature but same stack sharing concept might not applied on FSP 2.0 enabled platform, hence we are looking for some solution to bypass stack dependencies.
Reading the commit message of https://review.coreboot.org/c/coreboot/+/30310 it sounds like MP PPI feature is only available on FSP2.1. Is it available on all FSP2.0 platforms as well?
yes Patrick, we are getting push to enable this feature on few latest FSP 2.0 platform like WHL and CML as well.