Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46238 )
Change subject: soc/intel/broadwell: Convert to ASL 2.0 syntax ......................................................................
soc/intel/broadwell: Convert to ASL 2.0 syntax
Change-Id: Ie1b36e35c564414a4f9b36e120719857f55b862d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46238 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/pch/acpi/gpio.asl 1 file changed, 8 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/pch/acpi/gpio.asl b/src/soc/intel/broadwell/pch/acpi/gpio.asl index 6b20f27..bd9f581 100644 --- a/src/soc/intel/broadwell/pch/acpi/gpio.asl +++ b/src/soc/intel/broadwell/pch/acpi/gpio.asl @@ -58,17 +58,18 @@ Method (GWAK, 1, Serialized) { // Local0 = GPIO Base Address - Store (GPBS & ~1, Local0) + Local0 = GPBS & ~1
// Local1 = BANK, Local2 = OFFSET - Divide (Arg0, 32, Local2, Local1) + Local2 = Arg0 % 32 + Local1 = Arg0 / 32
// // Set OWNER to ACPI //
// Local3 = GPIOBASE + GPIO_OWN(BANK) - Store (Local0 + Local1 * 4, Local3) + Local3 = Local0 + (Local1 * 4)
// GPIO_OWN(BANK) OperationRegion (IOWN, SystemIO, Local3, 4) @@ -77,14 +78,14 @@ }
// GPIO_OWN[GPIO] = 0 (ACPI) - Store (GOWN & ~(1 << Local2), GOWN) + GOWN = GOWN & ~(1 << Local2)
// // Set ROUTE to SCI //
// Local3 = GPIOBASE + GPIO_ROUTE(BANK) - Store (Local0 + 0x30 + Local1 * 4, Local3) + Local3 = Local0 + 0x30 + (Local1 * 4)
// GPIO_ROUTE(BANK) OperationRegion (IROU, SystemIO, Local3, 4) @@ -93,14 +94,14 @@ }
// GPIO_ROUTE[GPIO] = 0 (SCI) - Store (GROU & ~(1 << Local2), GROU) + GROU = GROU & ~(1 << Local2)
// // Set GPnCONFIG to GPIO|INPUT|INVERT //
// Local3 = GPIOBASE + GPnCONFIG0(GPIO) - Store (Local0 + 0x100 + Arg0 * 8, Local3) + Local3 = Local0 + 0x100 + (Arg0 * 8)
// GPnCONFIG(GPIO) OperationRegion (GPNC, SystemIO, Local3, 8)