Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )
Change subject: soc/intel/tigerlake: Update ACPI files ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37781/3/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/37781/3/src/soc/intel/tigerlake/acp... PS3, Line 66: Device (I2C6) : { : Name (_ADR, 0x00100000) : Name (_DDN, "Serial IO I2C Controller 6") : Method (_PS0) { } : Method (_PS3) { } : } : : Device (I2C7) : { : Name (_ADR, 0x00100001) : Name (_DDN, "Serial IO I2C Controller 7") : Method (_PS0) { } : Method (_PS3) { } : } Delete this according to SOC_INTEL_I2C_DEV_MAX: 6 in Kconfig
https://review.coreboot.org/c/coreboot/+/37781/3/src/soc/intel/tigerlake/acp... PS3, Line 116: Device (SPI4) : { : Name (_ADR, 0x00130001) : Name (_DDN, "Serial IO SPI Controller 4") : Method (_PS0) { } : Method (_PS3) { } : } : : Device (SPI5) : { : Name (_ADR, 0x00130002) : Name (_DDN, "Serial IO SPI Controller 5") : Method (_PS0) { } : Method (_PS3) { } : } : : Device (SPI6) : { : Name (_ADR, 0x00130003) : Name (_DDN, "Serial IO SPI Controller 6") : Method (_PS0) { } : Method (_PS3) { } : } : Delete this according to SOC_INTEL_COMMON_BLOCK_GSPI_MAX: 4 in Kconfig
https://review.coreboot.org/c/coreboot/+/37781/3/src/soc/intel/tigerlake/acp... PS3, Line 165: Device (UAR3) : { : Name (_ADR, 0x00110000) : Name (_DDN, "Serial IO UART Controller 3") : Method (_PS0) { } : Method (_PS3) { } : } : : Device (UAR4) : { : Name (_ADR, 0x00110001) : Name (_DDN, "Serial IO UART Controller 4") : Method (_PS0) { } : Method (_PS3) { } : } : : Device (UAR5) : { : Name (_ADR, 0x00110002) : Name (_DDN, "Serial IO UART Controller 5") : Method (_PS0) { } : Method (_PS3) { } : } : : Device (UAR6) : { : Name (_ADR, 0x00110003) : Name (_DDN, "Serial IO UART Controller 6") : Method (_PS0) { } : Method (_PS3) { } : } : Delete acccording to SOC_INTEL_UART_DEV_MAX:3 in Kconfig
https://review.coreboot.org/c/coreboot/+/37781/3/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/smbus.asl:
https://review.coreboot.org/c/coreboot/+/37781/3/src/soc/intel/tigerlake/acp... PS3, Line 16: // Use C sytle comments like other asl