Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44939 )
Change subject: mb/google/dedede/var/drawcia: Add MIPI camera support
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44939/7/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44939/7/src/mainboard/google/dedede...
PS7, Line 272: register "nvm_compat" = ""atmel,24c08""
This nvm_compat seems to be redundant to the prior 4 lines that specify the NVM characteristics. If this line and the acpi_hid=ACPI_DT_NAMESPACE_HID line (line 260) was removed then I'd expect everything else to still work (since the device would end up with a _HID of INT3499, which will load the same driver and use nvm_size/nvm_pagesize/nvm_readonly/nvm_width properties).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96f2ef682dff851d7788c2b612765a92228ddf75
Gerrit-Change-Number: 44939
Gerrit-PatchSet: 7
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Andy Yeh
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Sep 2020 23:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment