Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44480 )
Change subject: mb/google/zork: Switch zork to use spd_tools ......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44480/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44480/9//COMMIT_MSG@8 PS9, Line 8: This CL is also making changes to soc/amd/picasso code. It would be good to capture that information as well in the commit message.
https://review.coreboot.org/c/coreboot/+/44480/9/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/ezkinil/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44480/9/src/mainboard/google/zork/v... PS9, Line 1: H5AN8G6NCJR-VKC,0 It would be good to add a note to commit message that HMAA1GS6CMR6N-VK was unused on ezkinil and so it is not being added here.
https://review.coreboot.org/c/coreboot/+/44480/9/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44480/9/src/mainboard/google/zork/v... PS9, Line 1: K4AAG165WA-BCWE, 0 : H5ANAG6NCMR-VKC, 1 : MT40A512M16TB-062E:J, 2 : MT40A1G16KD-062E:E, 3 : K4A8G165WC-BCWE, 4 : H5AN8G6NDJR-XNC, 5 : MT40A512M16TB-062E:J, 6 : K4AAG165WA-BCWE, 7 : H5ANAG6NCMR-XNC, 8 : K4A8G165WC-BCWE, 9 : MT40A1G16KD-062E:E, 10 Entries look confusing: 1. They do not match with what we currently have for Vilboz: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
2. There are duplicate entries for almost all parts?