11 Oct
2019
11 Oct
'19
11:02 a.m.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35967 )
Change subject: mb/google/poppy/variant/nocturne: don't invert GPP_D17 ......................................................................
Patch Set 1: Code-Review-2
I'm placing this CL into a -2 state as I'm not convinced yet that this is the right way to fix the problem and have some more investigation to do before I'm convinced. I will adjust the level back once I've completed those investigations if it's determined this is the right way to fix this problem.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1408ef6ea92f6b31a9f3eee8720954af3a7c382
Gerrit-Change-Number: 35967
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Gwendal Grignou gwendal@chromium.org
Gerrit-Reviewer: Gwendal Grignou gwendal@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Oct 2019 18:02:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment