Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45765 )
Change subject: console/init: Drop CONSOLE_LEVEL_CONST
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45765/2/src/console/init.c
File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/45765/2/src/console/init.c@26
PS2, Line 26: get_option(&debug_level, "debug_level");
Well, you are right about get_console_loglevel(). If we unify it with […]
If there are no other (strong) opinions, I'm going to update this to
call get_option() only late.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11484fc32dcbba8d31772bd0b82785f17b2fba11
Gerrit-Change-Number: 45765
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marc Jones
marc.jones@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Oct 2020 08:41:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-MessageType: comment