Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31323 )
Change subject: mb/asus/p5ql-em: Add mainboard ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Looks fine except for a few nits
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/board_inf... File src/mainboard/asus/p5ql-em/board_info.txt:
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/board_inf... PS4, Line 2: P5QC Seems wrong?
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/devicetre... File src/mainboard/asus/p5ql-em/devicetree.cb:
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/devicetre... PS4, Line 27: : Maybe inherit some subsystemid here to make the devicetree more compact
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/romstage.... File src/mainboard/asus/p5ql-em/romstage.c:
https://review.coreboot.org/#/c/31323/4/src/mainboard/asus/p5ql-em/romstage.... PS4, Line 135: /* TODO: FSB BSEL pins... */ Seems to be done above?