[coreboot-gerrit] [S] Change in coreboot[main]: soc/mediatek/mt8196: Add unmask eint event for bootblock

[Jarried Lin (Code Review)]

Attention is currently required from: Chhao Chang, Yidi Lin, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )

Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock
......................................................................

Patch Set 18:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84025/comment/5b73fdcb_90685334?usp... :
PS17, Line 12: '
> "

Done

https://review.coreboot.org/c/coreboot/+/84025/comment/f64348f5_c82399a7?usp... :
PS17, Line 12: '
> "

Done

https://review.coreboot.org/c/coreboot/+/84025/comment/ca645536_234b57db?usp... :
PS17, Line 16: 31709620
> Wrong bug?

Done

File src/soc/mediatek/common/eint_event.c:

https://review.coreboot.org/c/coreboot/+/84025/comment/ec3a1e26_ebc27e8a?usp... :
PS17, Line 15: uintptr_t reg;
> My approach do the same way.

Done

https://review.coreboot.org/c/coreboot/+/84025/comment/7a246179_bc373b53?usp... :
PS17, Line 8: #define EVENT_CLEAN_MASK_OFFSET	0x880
            : #define EVENT_MASK_OFFSET	0x800
            : #define EINT_VALUE		0xFFFFFFFF
            : 
            : void enable_eint_event(uintptr_t base, unsigned int port)
            : {
            : 	unsigned int i;
            : 	uintptr_t reg;
            : 
            : 	for (i = 0; i < port; i++) {
            : 		reg = base + EVENT_CLEAN_MASK_OFFSET + (i << 2);
            : 		write32((uint32_t *)reg, EINT_VALUE);
            : 	}
            : }
> That is why there should be eint_event_common.c.

Done

File src/soc/mediatek/common/include/soc/eint_event.h:

https://review.coreboot.org/c/coreboot/+/84025/comment/d50b10bc_5d7dbba2?usp... :
PS17, Line 17: struct eint_info {
             : 	uintptr_t base;
             : 	unsigned int eint_num;
             : };
> I uploaded CB:86033 to do the refactoring for you. Please take a look. […]

Done

File src/soc/mediatek/mt8196/bootblock.c:

https://review.coreboot.org/c/coreboot/+/84025/comment/e8c74353_ae4fbd3c?usp... :
PS17, Line 9: #include <soc/eint_event.h>
> sort

Done