Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47774 )
Change subject: ec/kontron/kempld: Add ACPI to access to internal registers ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47774/3/src/ec/kontron/kempld/acpi/... File src/ec/kontron/kempld/acpi/cpld.asl:
https://review.coreboot.org/c/coreboot/+/47774/3/src/ec/kontron/kempld/acpi/... PS3, Line 8: // _HID: Hardware ID I don't think we need these comments in every file.
https://review.coreboot.org/c/coreboot/+/47774/3/src/ec/kontron/kempld/acpi/... PS3, Line 13: Name (CPLR, ResourceTemplate () If you move this out of the method, it wouldn't need to be serialized. I'm not even sure if we need a named object at all, can't we
Return (ResourceTemplate () { IO (Decode16, ... ) })
https://review.coreboot.org/c/coreboot/+/47774/3/src/ec/kontron/kempld/acpi/... PS3, Line 25: Serialized Doesn't need to be serialized, does it?