Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35482 )
Change subject: superio/nuvoton/nct5104d: Add soft reset GPIO functionality ......................................................................
Patch Set 3:
Hm, I'm unsure if this functionality is board-dependent or if it something that should be done for every case the SIO will be used in, but I'd guess the former. Also IIRC the functionality added here will overwrite devicetree settings that would be written to the same registers, which might end up being surprising and hard to debug. Haven't really looked into if everything is set up so that setting this via the devicetree would be possible here though; might be an issue that it doesn\t only use registers in the 0xf? range, but also in the 0xe? range. Maybe have a configuration option in the chip.h file to enable this? I'm not sure what would be the best option here. The SIO/devicetree integration isn't that nice and requires a bit too much boilerplate, but that's what we currently have...