Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34599 )
Change subject: drivers/emulation/qemu: Show splashscreen on bochs VGA
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34599/2/src/drivers/emulation/qemu/...
File src/drivers/emulation/qemu/bochs.c:
https://review.coreboot.org/c/coreboot/+/34599/2/src/drivers/emulation/qemu/...
PS2, Line 126: if (CONFIG(BOOTSPLASH))
We already have the infrastructure to query the framebuffer parameters. […]
A part of the MULTIBOOT specification (for payloads/kernels) is that the header of such a file in CBFS can contain information about the preferred/required framebuffer. Maybe not related to this directly, but try reduce the use of build-time const CONFIG_FRAMEBUFFER_VESA_MODE.
IMHO that _VESA_MODE parameter should only be applied in the case of no available EDID.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4bec06d22423627e8f429c4b47e0dc9920f1464e
Gerrit-Change-Number: 34599
Gerrit-PatchSet: 2
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Gerd Hoffmann
kraxel@redhat.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 29 Jul 2019 14:08:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mimoja
coreboot@mimoja.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment