Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47569 )
Change subject: nb/intel/sandybridge: Clean up `dram_mr2` function ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47569/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/47569/2/src/northbridge/intel/sandy... PS2, Line 770: const u16 pasr = 0;
Is that variable needed at all? It only seems to be used once. […]
It's Partial Array Self-Refresh. It corresponds to the three low bits of MR2. I can drop it once I switch to common MR (Mode Register) helpers