Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30389 )
Change subject: arch/x86: Remove copy_and_run()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30389/3/src/arch/x86/include/arch/s...
File src/arch/x86/include/arch/stages.h:
https://review.coreboot.org/c/coreboot/+/30389/3/src/arch/x86/include/arch/s...
PS3, Line 17: #include <arch/cpu.h>
Possibly yes. Sometimes we require symmetry across different arch/ but this may not be the case. Might be better to check the other <arch/stages.h> to see if something should move there instead and remove these all.
I didn't see references in common files that would be included.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie443a27cf18f829496ddadcc19c4ebec6a0b5a59
Gerrit-Change-Number: 30389
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Nov 2019 07:14:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment