Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30973 )
Change subject: src/mainboard/sony: Add Sony VPCEH2K1E ......................................................................
Patch Set 6:
(10 comments)
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... File src/mainboard/sony/vpceh2k1e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... PS3, Line 33:
Specify Nvidia GPU's PCI ID here for the VBIOS
Done
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... File src/mainboard/sony/vpceh2k1e/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... PS3, Line 5: chip cpu/intel/socket_rPGA989 : device lapic 0x0 on : end : end
Recent patch changes this
Done
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... File src/mainboard/sony/vpceh2k1e/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... PS3, Line 21: #include <arch/acpi.h>
Space afterwards
Done
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... PS3, Line 31: /* Some generic macros */
Banish
Done
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... File src/mainboard/sony/vpceh2k1e/mainboard.c:
https://review.coreboot.org/c/coreboot/+/30973/3/src/mainboard/sony/vpceh2k1... PS3, Line 26: remove
Banish
Done
https://review.coreboot.org/c/coreboot/+/30973/4/src/mainboard/sony/vpceh2k1... File src/mainboard/sony/vpceh2k1e/romstage.c:
https://review.coreboot.org/c/coreboot/+/30973/4/src/mainboard/sony/vpceh2k1... PS4, Line 38: 0x82
Right... […]
Ack
https://review.coreboot.org/c/coreboot/+/30973/4/src/mainboard/sony/vpceh2k1... PS4, Line 38: 0x1c01
use macros in sb/intel/bd82x6x/pch. […]
Ack
https://review.coreboot.org/c/coreboot/+/30973/4/src/mainboard/sony/vpceh2k1... PS4, Line 40: pci_write_config32(PCI_DEV(0, 0x1f, 0), 0x88, 0x000c1641);
if you don't need to access those IO ranges in the romstage you should remove it here.
Ack
https://review.coreboot.org/c/coreboot/+/30973/4/src/mainboard/sony/vpceh2k1... PS4, Line 42: 0x80
LPC_IO_DEC
Ack
https://review.coreboot.org/c/coreboot/+/30973/5/src/mainboard/sony/vpceh2k1... File src/mainboard/sony/vpceh2k1e/romstage.c:
https://review.coreboot.org/c/coreboot/+/30973/5/src/mainboard/sony/vpceh2k1... PS5, Line 17:
#include <device/pci_ops.h> […]
Ack