[coreboot-gerrit] [L] Change in coreboot[master]: util/amdfwtool: Deal with psp position in flash offset directly

[Marvin Drees (Code Review)]

Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Arthur Heymans, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Marvin Drees has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69852 )

Change subject: util/amdfwtool: Deal with psp position in flash offset directly
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/69852/comment/7725f481_91f0a6e1 
PS4, Line 25: $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 1 $(CONFIG_AMD_FWM_POSITION))
> > I agree with what Karthik's saying here. […]

"The PSP really only cares about flash offsets, not x86 mmap offsets."
Christopher told me that this is not entirely true. There is a settings field in the image which allows you to set which mode it operates in, e.g. flash offset mode or x86 mmap offset I think. Though I'm not sure if the amdfwtool sets this or what the default mode was.