[coreboot-gerrit] Change in coreboot[master]: soc/skylake/vr_config: Add VR config for Skylake S

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35167 )

Change subject: soc/skylake/vr_config: Add VR config for Skylake S
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35167/3/src/soc/intel/skylake/vr_co... 
File src/soc/intel/skylake/vr_config.c:

https://review.coreboot.org/c/coreboot/+/35167/3/src/soc/intel/skylake/vr_co... 
PS3, Line 148: uint16_t icc_max[NUM_VR_DOMAINS] = {
             : 			VR_CFG_AMP(11.1),
             : 			VR_CFG_AMP(40),
             : 			VR_CFG_AMP(48),
             : 			VR_CFG_AMP(48),
             : 		};
> Right. […]

FSP 1.1 takes 5 values, FSP 2.0 takes 4 values. I made this earlier: http://dpaste.com/29MBM4R

Using a few larger tables (maybe a table per "series" (S-series, U-series, Y-series...) would make sense. I have to think it through, though.