Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35399 )
Change subject: lib/trace: Replace __PRE_RAM__ use ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35399/3/src/include/trace.h File src/include/trace.h:
https://review.coreboot.org/c/coreboot/+/35399/3/src/include/trace.h@19 PS3, Line 19: ENV_ROMSTAGE_OR_BEFORE
Are we just wanting to know if its RAMSTAGE? I think it's cleaner to use ENV_RAMSTAGE. […]
We build lib/trace.c for postcar and ramstage, so I chose this. Maybe lack of .bss was the reason why it was excluded from romstage?
With relocatable modules, I think we should normalize the printed addresses first? Like subtract _program perhaps? Maybe there is more that should be fixed, but maybe not in this commit scope...