Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42877 )
Change subject: soc/amd/common/gpio: Clear interrupt and wake status when configuring pads ......................................................................
Patch Set 4: Code-Review-2
(1 comment)
Waiting for a resolution on the event-logging situation before moving ahead with this.
https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42877/4/src/soc/amd/common/block/gp... PS4, Line 206: GPIO_WAKE_STATUS
Don't we reconfigure pins on S3 resume? Don't we want the wake status so that wake source reporting […]
Thanks for highlighting that Raul! I had that in mind, but didn't get a chance to sync up with Aaron on his work for eventlogging. I have added a comment here: b/159947207