Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32189 )
Change subject: ACPI: Add RHSA and ANDD structures for DMAR table ......................................................................
Patch Set 3:
(2 comments)
Please be patient with the review. It's not easy to get a new API right when nobody wrote a caller, yet.
https://review.coreboot.org/#/c/32189/2/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32189/2/src/arch/x86/acpi.c@592 PS2, Line 592: memcpy(&andd->device_name, device_name, 4);
Updated with variable length of acpi name-space object.
Ack, thanks
https://review.coreboot.org/#/c/32189/3/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32189/3/src/arch/x86/acpi.c@616 PS3, Line 616: oid acpi_dmar_rhsa_fixup(unsigned long base, unsigned long current) : { : dmar_rhsa_entry_t *rhsa = (dmar_rhsa_entry_t *)base; : rhsa->length = current - base; : } : : void acpi_dmar_andd_fixup(unsigned long base, unsigned long current) : { : dmar_andd_entry_t *andd = (dmar_andd_entry_t *)base; : andd->length = current - base; : } These structures don't end in variable length lists, so the length set above should already be correct.