Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31561 )
Change subject: payloads/tianocore: Add option for custom bootsplash ......................................................................
Patch Set 1:
(3 comments)
just some comments, not through yet
https://review.coreboot.org/#/c/31561/1/payloads/external/Makefile.inc File payloads/external/Makefile.inc:
https://review.coreboot.org/#/c/31561/1/payloads/external/Makefile.inc@138 PS1, Line 138: CONFIG_TIANOCORE_BOOTSPLASH_FILE="$(CONFIG_TIANOCORE_BOOTSPLASH_FILE)" \ CONFIG_* values should already contain quotes
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile File payloads/external/tianocore/Makefile:
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile... PS1, Line 92: if [[ "$(CONFIG_TIANOCORE_BOOTSPLASH_FILE)" = /* ]]; then \ [[ is non-standard, iirc
https://review.coreboot.org/#/c/31561/1/payloads/external/tianocore/Makefile... PS1, Line 95: $$(dirname "$$(dirname "$$(dirname "$(CURDIR)")")") Isn't $(top) available here?