[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Fix FSP UPDs settings with disabled GBE

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35595 )

Change subject: soc/intel/cannonlake: Fix FSP UPDs settings with disabled GBE
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35595/2/src/soc/intel/cannonlake/fs... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/35595/2/src/soc/intel/cannonlake/fs... 
PS2, Line 196: SlpS0WithGbeSupport
Isn't the default for this 0?

https://review.coreboot.org/c/coreboot/+/35595/2/src/soc/intel/cannonlake/fs... 
PS2, Line 207: && params->PchLanEnable
Just checking this should have been sufficient to not set SlpS0WithGbeSupport, right? Do you still need the lines 196-199?