build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44720 )
Change subject: soc/mediatek/mt8192: Do dramc tx window training ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44720/2/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44720/2/src/soc/mediatek/mt8192/dra... PS2, Line 2120: } else if (pi > pi_tap - 10) { please, no space before tabs
https://review.coreboot.org/c/coreboot/+/44720/2/src/soc/mediatek/mt8192/dra... PS2, Line 2408: if ((vref_win_perbit[bit].last_pass != Too many leading tabs - consider code refactoring
https://review.coreboot.org/c/coreboot/+/44720/2/src/soc/mediatek/mt8192/dra... PS2, Line 2415: if (perbit_winsum > TX_PASS_WIN_CRITERIA) Too many leading tabs - consider code refactoring