Attention is currently required from: Matt DeVillier, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78195?usp=email )
Change subject: configs: Clean up config.google.skyrim.with_binaries defconfig
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File configs/config.google_skyrim.with_binaries:
https://review.coreboot.org/c/coreboot/+/78195/comment/3a51c192_017e21d2 :
PS1, Line 11: CONFIG_FSP_M_FILE="3rdparty/amd_blobs/mendocino/MENDOCINO_M.fd"
: CONFIG_FSP_S_FILE="3rdparty/amd_blobs/mendocino/MENDOCINO_S.fd"
those are the defaults for mendocino now, so those two lines should probably just be dropped. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6d355b838d30dca64a9e6206eb6000763cc105a1
Gerrit-Change-Number: 78195
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 04 Oct 2023 09:59:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment