Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37297 )
Change subject: mb/lenovo/x220/devicetree: Use subsystemid inheritance ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/lenovo/x220/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37297/comment/37a14db5_95100368 PS4, Line 108: subsystemid 0x17aa 0x21fa
Oopsm thanks for pointing on it. Looks like a typo, yes. Let me investigate why I did it first.
I think I've got access to a different X220. I've just grep through the database of Lenovo lspci dumps (see here https://github.com/linuxhw/LsPCI/tree/master/Notebook/Lenovo/ThinkPad ) and here is what I've got:
Sulaco ~/work/LsPCI (git::master): grep -R Ricoh Notebook/Lenovo/ThinkPad/ThinkPad\ X220\ * -A 1 |grep -o "Subsystem: Lenovo Device [17aa:.*]" |LANG=C sort| uniq -c 136 Subsystem: Lenovo Device [17aa:21da] 35 Subsystem: Lenovo Device [17aa:21db] 2 Subsystem: Lenovo Device [17aa:21fa] Sulaco ~/work/LsPCI (git::master):
So certainly there are machines with 0x21fa, 0x21db and 0x21da PCI IDs. Don't know how to handle it but it *looks* like (I'm not sure) that 0x21da is a most popular PCI ID.