V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47430 )
Change subject: soc/intel/common: Add Kconfig for CSE RW firmware version
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47430/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47430/7//COMMIT_MSG@10
PS7, Line 10: maiboard
mainboard
Done
https://review.coreboot.org/c/coreboot/+/47430/7//COMMIT_MSG@12
PS7, Line 12:
Can you document, that the firmware version is not stored in the blob itself? (Maybe it should be in […]
Done
https://review.coreboot.org/c/coreboot/+/47430/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/47430/7/src/soc/intel/common/block/...
PS7, Line 51: major.minor.hotfix.build.
Can you give one example?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62691ee3ede7d4cd21f821381f5d1519f9061fd9
Gerrit-Change-Number: 47430
Gerrit-PatchSet: 8
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 15 Nov 2020 15:16:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment