Hello ron minnich, Subrata Banik, Matt DeVillier,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/33263
to review the following change.
Change subject: Kconfig: Guard RAMPAYLOAD ......................................................................
Kconfig: Guard RAMPAYLOAD
The RAMPAYLOAD symbol added by 7e893a02c0 (Kconfig: Create RAMPAYLOAD kconfig) is shown unconditionally for all x86 systems. It generally creates a lot of confusion to prompt for something that isn't imple- mented or not working. So guard it with another Kconfig that can be selected by platforms that actually support it.
Change-Id: I6d158382d1000b8b40ca1368e2efff0c39884f15 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/Kconfig 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/33263/1
diff --git a/src/Kconfig b/src/Kconfig index d30aa99..49f8e6e 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -277,10 +277,13 @@ The path and filename of the file to use as graphical bootsplash screen. The file format has to be jpg.
+config HAVE_RAMPAYLOAD + bool + config RAMPAYLOAD bool "Enable coreboot flow without executing ramstage" default n - depends on ARCH_X86 + depends on HAVE_RAMPAYLOAD help If this option is enabled, coreboot flow will skip ramstage loading and execution of ramstage to load payload.