Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36843 )
Change subject: mb/ocp/monolake: Override SMBIOS UUID with the value get from BMC
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36843/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36843/4//COMMIT_MSG@7
PS4, Line 7: value get from BMC
value sent by BMC
or
value from BMC
https://review.coreboot.org/c/coreboot/+/36843/4//COMMIT_MSG@9
PS4, Line 9: and the UUID is expected
the expected UUID is visible.
https://review.coreboot.org/c/coreboot/+/36843/4/src/mainboard/ocp/monolake/...
File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/36843/4/src/mainboard/ocp/monolake/...
PS4, Line 99: value get from BMC
value from BMC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36843
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0aab4df67b7aaba8be6ddbb13984fffb2b14fe6b
Gerrit-Change-Number: 36843
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 20 Nov 2019 15:14:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment