Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30973 )
Change subject: src/mainboard/sony: Add Sony VPCEH2K1E
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/30973/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30973/5//COMMIT_MSG@21
PS5, Line 21: TODO: Use FMAP to put EC firmware in its place
Tested, required.
https://review.coreboot.org/#/c/30973/5/src/mainboard/sony/vpceh2k1e/romstag...
File src/mainboard/sony/vpceh2k1e/romstage.c:
https://review.coreboot.org/#/c/30973/5/src/mainboard/sony/vpceh2k1e/romstag...
PS5, Line 17:
#include <device/pci_ops.h>
#include <device/pnp_ops.h>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30973
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf324f1276611ab06d5906cab87ad538bfad7218
Gerrit-Change-Number: 30973
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Mar 2019 16:23:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment