Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46492 )
Change subject: sec/intel/txt/common.c: Only log ACM error on failure
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46492/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46492/3//COMMIT_MSG@9
PS3, Line 9: The TXT_BIOSACM_ERRORCODE register is only valid if bit 62 is set, or if
I think I mixed some of these registers up at some point. Let me check...
Ah, I just forgot to specify the bits are in the TXT_SPAD register.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If047ad79f12de5e0f34227198ee742b9e2b5eb54
Gerrit-Change-Number: 46492
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 20 Oct 2020 13:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment