Attention is currently required from: Kevin Chiu, Tarun Tuli, Eric Lai, Ricky Chang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68916 )
Change subject: mb/google/brya/var/lisbon: turn off thunderbolt
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68916/comment/f473b4c5_87be3d65
PS1, Line 7: turn off thunderbolt
Done
It doesn't seem like much, but could you please change it?
You can easily edit the commit message from Gerrit's Web UI, there's an "EDIT" button on the bottom right corner of the box showing the commit message: https://imgur.com/NQXe1hL.png
https://review.coreboot.org/c/coreboot/+/68916/comment/90e845a9_9e1e173d
PS1, Line 9: no support thunderbolt on lisbon
Done
Eric's suggestion is a well-formed sentence, though. Could you please change it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68916
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac44315d000c3c0c572efb00e877d039e0308455
Gerrit-Change-Number: 68916
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ricky Chang
rickytlchang@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Ricky Chang
rickytlchang@google.com
Gerrit-Comment-Date: Sun, 06 Nov 2022 15:07:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu
kevin.chiu.17802@gmail.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment