Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46605 )
Change subject: [RFC] Replace strapping_id entries with new board configuration entry
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46605/1/src/lib/coreboot_table.c
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/46605/1/src/lib/coreboot_table.c@20
PS1, Line 20: #include <version.h>
Uh, why sort at all? And why sort only a part of the list?
If I ever get too annoyed by headers being out-of-order, I sort them beforehand.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ecec847ee77b72233587c1ad7f124e2027470bf
Gerrit-Change-Number: 46605
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 21 Oct 2020 22:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment