Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32907 )
Change subject: [WIP] Documentation: How to run coreboot on PC Engines apu1 ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/#/c/32907/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32907/1//COMMIT_MSG@7 PS1, Line 7: [WIP] You can tag this WIP in Gerrit, so you do not need to amend the commit message.
https://review.coreboot.org/#/c/32907/1//COMMIT_MSG@7 PS1, Line 7: apu1 APU1
https://review.coreboot.org/#/c/32907/1//COMMIT_MSG@8 PS1, Line 8: : There were no documentation about running coreboot on apu1 platform, so now it describes how to do this. Please wrap the line after 75/72 characters.
https://review.coreboot.org/#/c/32907/1//COMMIT_MSG@9 PS1, Line 9: were is
https://review.coreboot.org/#/c/32907/1//COMMIT_MSG@11 PS1, Line 11: Signed-off-by: Piotr Kleinschmidt piotr.kleinschmidt@3mdeb.com Please move it below the Change-Id line.
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... File Documentation/mainboard/pcengines/apu1.md:
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 1: apu1 APU1
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 31: [flashrom] Does this work? Shouldn’t it be `[flashrom][]`?
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 34: `flashrom -p internal -c MX25L1606E -w coreboot.rom ` Please remove the `…` and indent it with four spaces.
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 39: ACPI : Specification documentation Add a link?
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 43: which is Can be removed.
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 48: to programmer device to *the* …
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 49: a linux_spi a linux_spi *device*?
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 52: `flashrom -w coreboot.rom -p linux_spi:dev=/dev/spidev1.0,spispeed=16000 -c : "MX25L1606E"` Indent this please instead of using backticks.
https://review.coreboot.org/#/c/32907/1/Documentation/mainboard/pcengines/ap... PS1, Line 63: [here]: https://www.coreboot.org/Binary_situation Where is this used?