Attention is currently required from: Rex-BC Chen. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56106 )
Change subject: vc/mediatek/mt8195: Enable DRAM Vcore DVFS settings ......................................................................
Patch Set 3:
(1 comment)
File src/vendorcode/mediatek/mt8195/dramc/dramc_top.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/71bf4697_381fcca4 PS3, Line 355: #elif CONFIG(CHROMEOS)
How is this ChromeOS specific?
I think the 'CHROMEOS' flag is used more like 'settings for Chromebook' - since there were comments [FOR CHROMEOS].
But it's true using CONFIG(CHROMEOS) here is not a good idea since the config in coreboot has a more specific meaning - build particular firmware (with vboot etc) for Chrome OS, not just Chromebooks.
@Rex can you change these (also the other configs in same file) to
#else // [FOR CHROMEOS / COREBOOT] return .... #endif