Attention is currently required from: Jonathan Zhang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48946 )
Change subject: mb/ocp/deltalake: Override DDR frequency limit via VPD variable ......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/48946/comment/52b63074_9ce11c6d PS8, Line 82: ddr_freq_limit DdrFreqLimit(int num) open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/48946/comment/3af15351_5861302c PS8, Line 104: printk(BIOS_WARNING, "Invalid DdrFreqLimit value from VPD: " Prefer using '"%s...", __func__' to using 'DdrFreqLimit', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/48946/comment/f62034c5_7540b19c PS8, Line 112: printk(BIOS_INFO, "Setting DdrFreqLimit %d from VPD\n", val_int); Prefer using '"%s...", __func__' to using 'DdrFreqLimit', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/48946/comment/2022e602_40f28532 PS8, Line 116: "DdrFreqLimit to %d\n", FSP_DIMM_FREQ, Prefer using '"%s...", __func__' to using 'DdrFreqLimit', this function's name, in a string