[coreboot-gerrit] [L] Change in coreboot[master]: util/amdfwtool: Deal with psp position in flash offset directly

[Arthur Heymans (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69852 )

Change subject: util/amdfwtool: Deal with psp position in flash offset directly
......................................................................

Patch Set 4:

(1 comment)

File src/soc/amd/common/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/69852/comment/cd9dfeee_b0019aed 
PS4, Line 25: $(call int-subtract, 0xffffffff $(CONFIG_ROM_SIZE)) 1 $(CONFIG_AMD_FWM_POSITION))
> Earlier the position was in memory map 0xffc20000 and the SPI ROM was in the memory map range [0xff800000..0xffffffff]. So it was right.
>
> Now that we have redefined the meaning of AMD_FWM_POSITION to be flash offset, we have to define more offsets(not just 6) such that this arithmetic fit within the memory map.

I'm not sure I understand. The PSP looks at 6 different offsets which are always a flash offset. cbfstool does not understand flash offset (only relative offsets in regions). So the trick is to translate it to the memory mapped offset.