Attention is currently required from: Andrey Petrov.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74204 )
Change subject: src/commonlib/fsp_relocate.c: Fixed NULL pointer dereferencing nparsed need not pass NULL for offsets other than 0. fih_offset is set only when the value stored in it is 0. Hence no need to pass a NULL pointer to indicate the offset is 0. ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173187): https://review.coreboot.org/c/coreboot/+/74204/comment/b758f76b_d838620b PS1, Line 6: Possible long commit subject (prefer a maximum 65 characters)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173187): https://review.coreboot.org/c/coreboot/+/74204/comment/f878a6fe_fbdd8213 PS1, Line 12: Must return when fsp_version_cbmem is NULL, else the pointer is dereferenced Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173187): https://review.coreboot.org/c/coreboot/+/74204/comment/b2ada1df_e02ca7ad PS1, Line 15: usb4_path must be freed before exiting the fucntion as it is not used elsewhere Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173187): https://review.coreboot.org/c/coreboot/+/74204/comment/a9188090_aa0d5a09 PS1, Line 15: usb4_path must be freed before exiting the fucntion as it is not used elsewhere 'fucntion' may be misspelled - perhaps 'function'?
File src/drivers/intel/fsp2_0/memory_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-173187): https://review.coreboot.org/c/coreboot/+/74204/comment/81252afa_36857da3 PS1, Line 59: if (!fsp_version_cbmem){ space required before the open brace '{'