Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28640 )
Change subject: mb/clevo/kbl-u: Add Clevo N130WU/N131WU
......................................................................
Patch Set 147: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/28640/147/src/mainboard/clevo/kbl-u...
File src/mainboard/clevo/kbl-u/variants/n13xwu/gpios.c:
https://review.coreboot.org/c/coreboot/+/28640/147/src/mainboard/clevo/kbl-u...
PS147, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
what about gpio.c instead of gpios.c?
https://review.coreboot.org/c/coreboot/+/28640/147/src/mainboard/clevo/kbl-u...
PS147, Line 5:
TODO: convert to macros and check by schematics (I can do this if you want)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513
Gerrit-Change-Number: 28640
Gerrit-PatchSet: 147
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Shaleen jain
shaleen@jain.sh
Gerrit-Comment-Date: Thu, 19 Nov 2020 14:49:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment