Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41800 )
Change subject: soc/intel/tigerlake/acpi: Update gpio_op.asl to ASL2.0 syntax ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41800/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/gpio_op.asl:
https://review.coreboot.org/c/coreboot/+/41800/1/src/soc/intel/tigerlake/acp... PS1, Line 79: Local0 = VAL0 : Local0 = ~PAD_CFG0_MODE_MASK & Local0 could combine this to just
Local0 = ~PAD_CFG0_MODE_MASK & VAL0
https://review.coreboot.org/c/coreboot/+/41800/1/src/soc/intel/tigerlake/acp... PS1, Line 81: >> << ?