Attention is currently required from: Martin Roth, Nick Kochlowski.
Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85635?usp=email )
Change subject: drivers/amd/opensil/romstage.c: Implement cbmem_top_chipset in driver
......................................................................
Patch Set 12:
(2 comments)
Patchset:
PS12:
rest looks good
File src/vendorcode/amd/opensil/opensil.h:
https://review.coreboot.org/c/coreboot/+/85635/comment/c930c52f_da26baae?usp... :
PS12, Line 16: uintptr_t
uintptr_t needs the include defining that; not sure if inttypes.h or types.h would be the better one to include in this file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85635?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc79456b0429cdd3d8e3fa5c224799a05add8359
Gerrit-Change-Number: 85635
Gerrit-PatchSet: 12
Gerrit-Owner: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 10 Jan 2025 22:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No