Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33622 )
Change subject: vendorcode/amd/pi: Integrate Merlin Falcon as a build option
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33622/10/src/vendorcode/amd/pi/Kcon...
File src/vendorcode/amd/pi/Kconfig:
https://review.coreboot.org/c/coreboot/+/33622/10/src/vendorcode/amd/pi/Kcon...
PS10, Line 48: if SOC_AMD_STONEYRIDGE_FP4 ||
I'm just pointing out that by saying || !HAVE_MERLINFALCON_BINARIES here, that will be the new defau […]
I see your point... if I added anything new below this line there would be a problem. Will change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id3341f6a1ef2561a6391d3db8c54f6bdd09b0c0e
Gerrit-Change-Number: 33622
Gerrit-PatchSet: 10
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jul 2019 22:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment