Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37561 )
Change subject: drivers/intel/fsp2_0: Allow to add FSP binaries from repo for IceLake
......................................................................
Patch Set 7:
Should we drop `vendorcode/intel/fsp/fsp2_0/icelake/`?
Maybe I misunderstand things, but adding the option to read it for the 3rdparty repo is there to be an addition. It still should work without the in-tree repo checked out, right?
Not really. Well, depends on what should work. It wouldn't boot anyway
without the binaries. And for build tests, we assume the 3rdparty/ repos
to be checked out.
It's not a requirement to drop the stale copies now. Still, I'd like to
take the opportunity to discuss it. Otherwise we might drag them along
for ever without anybody making use of them.
Shall we merge it like this and I open an additional CR to cleanup vendorcode/intel/fsp2_0 ?
If you are in a hurry, we can do that. I would just have waited
for people to comment here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29faa8d3acff5680b611951fc193d33f514dc0d3
Gerrit-Change-Number: 37561
Gerrit-PatchSet: 7
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 07 Dec 2019 19:04:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment