Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32381 )
Change subject: soc/intel/braswell: add default option to use public FSP
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
I2CxFrequency must be removed from Braswell and moved to MR1 mainboard directory.
Please have a look into patch: https://review.coreboot.org/c/coreboot/+/29661
https://review.coreboot.org/#/c/32381/6/src/soc/intel/braswell/chip.c
File src/soc/intel/braswell/chip.c:
https://review.coreboot.org/#/c/32381/6/src/soc/intel/braswell/chip.c@172
PS6, Line 172: params->I2C0Frequency = config->I2C0Frequency;
I2C0Frequency -- I2C6Frequency do not exist in SILICON_INIT_UPD of FSP MR2
3rdparty Braswell FspUpdVpd.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43cf18b98c844175a87b61fdbe4b0b24484e5702
Gerrit-Change-Number: 32381
Gerrit-PatchSet: 6
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 24 Apr 2019 13:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment