Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48842 )
Change subject: soc/amd/common: Detect SOC before access ESPI register ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48842/1/src/soc/amd/common/block/lp... File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/48842/1/src/soc/amd/common/block/lp... PS1, Line 828: SOC_AMD_CEZANNE
Please do not add SoC specific checks in common code. […]
only had a very brief look, but adding a Kconfig option in soc/amd/common/block/lpc/Kconfig like ESPI_SUPPORTS_SUBTRACTIVE_DECODE that gets selected by stoneyridge and picasso should probably be the way to go. might also be worth a look if LPC still supports subtractive decode; if that was also dropped there, dropping the ESPI_ from the kconfig symbol and also using it in the LPC code would be good